Hi, sorry to be late on the train.I am trying to review some of the PRs, and I think it would be useful (at least for me):* an hint on how to checkout (if at all possible) PRs without the gh CLI* since we started using docker at least for tests, is there a guide on how to spin it up for local tests (from a local checkout, so to test PRs)?I admit I didn't use GH much, because I prefer my local git repos (backed up also in GH and GL), these may be trivial questions/problems.I will continue reviewing to the best of my possibilities, but I think addressing the above could ease the path for new contributors.My first issue is this: I run a basic build with the stable tree, and I succeeded to install it.I then checked out a PR with gh pr checkout 585 and the build attempt failed with:In file included from /home/nicola/Documents/dev/xymon/include/libxymon.h:81,
from cgi.c:24:
/home/nicola/Documents/dev/xymon/include/../lib/loadalerts.h:20:10: fatal error: pcre2.h: File o directory non esistente
20 | #include <pcre2.h>
| ^~~~~~~~~I remember switching to more modern PCRE, but this also means PRs are based on a new branch which should be checked out as a baseline before attempting new builds, right?NicolaIl giorno dom 18 ott 2026 alle ore 12:23 Roland Rosenfeld via Xymon <xymon@xymon.com> ha scritto:On Do, 08 Okt 2026, Bruno Manzoni via Xymon wrote:
> Seven years after 4.3.30, a new Xymon is nearly ready, and it's a big one:
>
> code tests docs
> 241 merged PRs +5,342 -1,546 +13,266 -2,092 6,497
> 9 still open +267 -104 +981 -5 157
Ten days later we still have 9 PRs open for 4.3.31 (okay, #661 should
be trivial to approve and I just approved #636), but I fear we won't
ever reach the point where all PRs for milestone 4.3.31 are merged.
I thought about reviewing the remaining 7 PRs, but I fear my C skills
are too limited for this...
So maybe we should just release 4.3.31 as it is now and move the open
PRs to 4.3.32.
>From my point of view the current 4.3.31 HEAD is much better than
seven year old 4.3.30 (also without the last PRs applied) and would be
a big step forward for all users.
At least for me as Debian maintainer of the package an early release
would make life easier since it would be the end of trying to keep old
4.3.30 alive in Debian while in parallel try to keep/merge all changes
from the 241 merged PRs into an upcoming Debian package. A fixed
milestone, which I could release in Debian would make this much
easier...
So what is really missing to release 4.3.31? Add the latest changes
to Changes branch (update Changes and RELEASENOTES) and merge them
into the main branch and then just do the release process...
I's suggest doing so sooner than later. And after this do a restart
with 4.3.32.
Greetings
Roland
_______________________________________________
Xymon mailing list -- xymon@xymon.com
To unsubscribe send an email to xymon-leave@xymon.com