Hi
Stef,
Thanks
for reviewing the PR!
Bruno
Le 17.06.2026 à 10:17, Stef Coene a
écrit :
Hi,
I'm not really a C-programmer but I will take a look at the PR's.
From other projects, I learned that a discord chat (or in an other
app) is helpful to quickly get answers and feedback.
Certainly in cases where there is a discussion or disagreement on
how something should be implemented.
Stef
On 2026-06-16 23:24, Bruno Manzoni via Xymon wrote:
Hi guys,
We currently have 35 PRs that appear ready but are not being
merged because nobody is reviewing them.
To make code review lighter, I propose modifying our governance
as follows:
* Typos, comments, and documentation: no review required.
* Build/CI fixes: review optional.
* Test framework changes: review optional.
* Refactoring without behavior changes: review optional.
* Bug fixes: one review required before merge.
* New features: one review required before merge, with review
encouraged at the start and during development when
practical.
* Architectural changes: one review required before merge,
with review
encouraged at the start and during development when
practical.
Let me know what you think.
Also, if someone could review PR #158 (normally the last
remaining patch before all Debian and FreeBSD patches are
integrated), I would appreciate it. For a new feature like this,
I am particularly interested in feedback on:
* Whether the tests cover the expected use cases and edge
cases.
* Whether the implementation is understandable and
maintainable.
* Whether the user interface and behavior are intuitive.
* Any obvious issues, limitations, or potential improvements.
If everything goes well, a release could be expected fairly soon
afterwards.
Thanks,
Bruno
_______________________________________________
Xymon mailing list -- xymon@xymon.com
To unsubscribe send an email to xymon-leave@xymon.com
_______________________________________________
Xymon mailing list -- xymon@xymon.com
To unsubscribe send an email to xymon-leave@xymon.com