Hi all,
Nicola raised three points while reviewing the c-ares change
(#138). Two are done, and the third needs your opinion.
1. Release notes. Each pull request now writes its own
RELEASENOTES entry (#674), so reviewers and testers see what
administrators will be told alongside the change. The 4.3.31
section on main already covers:
- client filesystem reporting;
- alerting;
- page filters;
- the web pages;
- network tests;
- the build, including the switch to the system c-ares and to
PCRE2.
19 open pull requests carry theirs.
2. Install guide. docs/install.html was rewritten (#672):
- each system has its own package list, with c-ares and PCRE2
named;
- it says Xymon no longer ships its own c-ares;
- it says 4.3.30 is the last release that builds with the old
PCRE.
3. Version shown by a build: comments welcome on the proposal.
Every build since 4.3.30 says "Xymon 4.3.30" in its web page
footers. That includes builds from main, which already carry
everything merged for 4.3.31. The version used to be changed by
hand at each release and release candidate, and that stopped.
The proposal in https://github.com/xymon-monitoring/xymon/issues/676
makes this automatic, with nothing to do per release:
- Released versions and their tarballs show the release number
(4.3.31), as today.
- Builds from git show where they come from, for example
4.3.31+12.gdef5678, meaning 12 commits after 4.3.31.
Where the full form appears:
- the page footer;
- --version and the status columns of the Xymon programs;
- xymond's answer to ping;
- a new XYMONBUILD for extension scripts.
XYMONDREL and the HTTP tests' User-Agent stay on the release
number.
One case to check: a client without a clientupdate level sends
xymon --version as its clientversion, and the client script
compares that exactly with the version the server asks for. It
should be harmless, since such servers usually ask for none, but
does anything you run rely on it, or compare the other values
exactly?
The issue lists every place the version appears, and the other
approaches considered. If you see a better one, say so. Comments
are welcome on the issue or here on the list.
Thanks, Nicola, for raising these.
Bruno
@canepan commented on this pull request.
> @@ -86,7 +86,7 @@ The GNU C compiler works fine on HP-UX. More details in <a href="http://www.xymon.com/archive/2005/06/msg00079.html">this e-mail</a> from the Xymon mailing list.</p> -<h4>PCRE, RRDtool, OpenSSL, OpenLDAP libraries.</h4> +<h4>PCRE, RRDtool, c-ares, OpenSSL, OpenLDAP libraries.</h4>Nice: I don't understand where this automation is triggered, but I trust it will work.
Do we have something similar to show the (pre-release) version on the web pages as it happened in the past (before 4.3.30)?—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you authored the thread.
