Hello.
xymon/build/Makefile.rules contains find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -print0 | xargs -0 chmod 644
what about to change it ? For example to find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -exec chmod 644 {} \;
Some time $(INSTALLWWWDIR) may be empty. Building brake at this case:
make[1]: Leaving directory /home/builder/RPM/BUILD/xymon-4.3.13/web' find /home/builder/tmp-build/xymon-buildroot/var/www/xymon -type f -print0 | xargs -0 chmod 644 chmod: missing operand after 644'
Try `chmod --help' for more information.
-- Regards, Sergey
Den 2014-02-12 10:33, Sergey skrev:
Hello.
xymon/build/Makefile.rules contains find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -print0 | xargs -0 chmod 644
what about to change it ? For example to find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -exec chmod 644 {} \;
Some time $(INSTALLWWWDIR) may be empty. Building brake at this case:
I don't quite understand how this can be. The $(INSTALLWWWDIR) directory should always have some files in it - e.g. the gifs and help files that get installed prior to the line that breaks.
make[1]: Leaving directory
/home/builder/RPM/BUILD/xymon-4.3.13/web' find /home/builder/tmp-build/xymon-buildroot/var/www/xymon -type f -print0 | xargs -0 chmod 644 chmod: missing operand after644' Try `chmod --help' for more information.
Here it seems like you are building an RPM package. Are you sure this isn't caused by some error in the spec-file ?
Regards, Henrik
On Wed, February 12, 2014 6:17 am, henrik at hswn.dk wrote:
Den 2014-02-12 10:33, Sergey skrev:
Hello.
xymon/build/Makefile.rules contains find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -print0 | xargs -0 chmod 644
what about to change it ? For example to find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -exec chmod 644 {} \;
Some time $(INSTALLWWWDIR) may be empty. Building brake at this case:
I don't quite understand how this can be. The $(INSTALLWWWDIR) directory should always have some files in it - e.g. the gifs and help files that get installed prior to the line that breaks.
make[1]: Leaving directory `/home/builder/RPM/BUILD/xymon-4.3.13/web' find /home/builder/tmp-build/xymon-buildroot/var/www/xymon -type f -print0 | xargs -0 chmod 644 chmod: missing operand after `644' Try `chmod --help' for more information.
Here it seems like you are building an RPM package. Are you sure this isn't caused by some error in the spec-file ?
Regards, Henrik
I remember seeing this while doing PKGBUILD=1 builds in my RPM too, starting right in the 4.3.13 release. I patched around it (below) and promptly forgot about it... but never tracked down precisely what had changed in the build path. It could be affecting yours too. HTH, -jc --- build/Makefile.rules.safexargs 2014-01-09 12:54:44.780844602 -0800 +++ build/Makefile.rules 2014-01-09 12:59:00.575844602 -0800 @@ -332 +332 @@ - find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -print0 | xargs -0 chmod 644 + find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -print0 | xargs -r -0 chmod 644
On Wednesday 12 February 2014, henrik at hswn.dk wrote:
Here it seems like you are building an RPM package. Are you sure this isn't caused by some error in the spec-file ?
No, but I found the problem. My rpm package based on package from J.C. Cleaver. It contais xymon_4313.installstaticwww.patch which move static data outside directory which contains in $(INSTALLWWWDIR).
By the way it is a good idea I think: it is allow to use tmpfs for /var/www/xymon with regenerable data. Is it good to include to main code maybe ?
-- Regards, Sergey
On Wed, February 12, 2014 11:09 pm, Sergey wrote:
On Wednesday 12 February 2014, henrik at hswn.dk wrote:
Here it seems like you are building an RPM package. Are you sure this isn't caused by some error in the spec-file ?
No, but I found the problem. My rpm package based on package from J.C. Cleaver. It contais xymon_4313.installstaticwww.patch which move static data outside directory which contains in $(INSTALLWWWDIR).
Hmm. Are you using any unusual options (or rewrites) during the package rebuild? AFAIK every version of the RPM on the site should have the earlier (xargs) patch applied along with it, which covers this. If that's not the case, it's definitely a bug on my part.
Regards, -jc
On Thursday 13 February 2014, you wrote:
Are you using any unusual options (or rewrites) during the package rebuild ?
Yes. I used only 4.3.10-1.fc17.src.rpm fully. I look to your SRPM time to time since then.
If that's not the case, it's definitely a bug on my part.
No your bug. :-) I did not seen your correction for this case.
-- Regards, Sergey
Hi,
Den 2014-02-12 10:33, Sergey skrev:
Hello.
xymon/build/Makefile.rules contains find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -print0 | xargs -0 chmod 644
what about to change it ? For example to find $(INSTALLROOT)$(INSTALLWWWDIR) -type f -exec chmod 644 {} \;
Some time $(INSTALLWWWDIR) may be empty.
I think this is only a problem when building packages that use a non-default directory layout. But there is no reason not to apply this change, so I have included it for the next version.
Regards, Henrik
participants (3)
-
a_s_y＠sama.ru
-
cleaver＠terabithia.org
-
henrik＠hswn.dk