Xymongen - clientlog column - bug?
Hello,
Using the Terabithia 4.3.30 RPMs, the Xymongen web page shows some statistics such as the total number of status messages, and their breakdown into how many were green, how many red and so on.
In looking at the source code where the number of status messages is counted up though, I am a bit confused. The code shows:
======= /* Count all of the real columns */ if ( (strcmp(testname, xgetenv("INFOCOLUMN")) != 0) && (strcmp(testname, xgetenv("TRENDSCOLUMN")) != 0) ) {
In other words, this says add up the number of green, red etc messages except for the 'info' and 'trends' columns. This makes sense as these two columns do not test anything, they just report known information.
My question is why is the 'clientlog' column not also excluded? It too does not 'test' anything, but just reports the data sent by the client.
In trying to work out the number of tests we have I have been checking the '/var/lib/xymon/hist' directory. Looking just at test names, in our case, we have 1165 test results. However, the xymongen web page shows 1215 status messages. By modifying the code to include a count of the clientlog messages on the xymongen web page, this shows 50. Now, 1215 - 50 = 1165.
So, as far as I can tell, the number of status messages being displayed is incorrect. It is higher than it should be. I can submit a patch to correct this, it's just a one-line change, but I want to be sure that it is actually a bug.
John.
-- John Horne | Senior Operations Analyst | Technology and Information Services University of Plymouth | Drake Circus | Plymouth | Devon | PL4 8AA | UK
[http://www.plymouth.ac.uk/images/email_footer.gif]<http://www.plymouth.ac.uk/worldclass>
This email and any files with it are confidential and intended solely for the use of the recipient to whom it is addressed. If you are not the intended recipient then copying, distribution or other use of the information contained is strictly prohibited and you should not rely on it. If you have received this email in error please let the sender know immediately and delete it from your system(s). Internet emails are not necessarily secure. While we take every care, University of Plymouth accepts no responsibility for viruses and it is your responsibility to scan emails and their attachments. University of Plymouth does not accept responsibility for any changes made after it was sent. Nothing in this email or its attachments constitutes an order for goods or services unless accompanied by an official order form.
The 'clientlog' column is populated by information sent from the client. Why shouldn't it be included in the count of messages of type=status?
Do things because you should, not just because you can.John Thurston 907-465-8591 John.Thurston at alaska.gov Department of Administration State of Alaska
On 10/21/2019 1:19 PM, John Horne wrote:
Using the Terabithia 4.3.30 RPMs, the Xymongen web page shows some statistics such as the total number of status messages, and their breakdown into how many were green, how many red and so on.
On Mon, 2019-10-21 at 13:29 -0800, John Thurston wrote:
The 'clientlog' column is populated by information sent from the client. Why shouldn't it be included in the count of messages of type=status?
Well I did wonder myself. But the count of status messages determines the percentages for the number of green, red etc messages (as shown on the xymongen web page). So if the number is wrong, then so are those percentages.
The thing is that 'clientlog' is not a test. It does not report back as red or yellow, it's always green (unless I've misinterpreted something). Because of this the number of green messages does not truly reflect the number of green 'test' results. So it could be argued that the status count should record all status messages, or it should only record those from actual tests and the 'info, 'trends' and 'clientlog' messages should be ignored.
John.
On 10/21/2019 1:19 PM, John Horne wrote:
Using the Terabithia 4.3.30 RPMs, the Xymongen web page shows some statistics such as the total number of status messages, and their breakdown into how many were green, how many red and so on.
Xymon mailing list Xymon at xymon.com http://lists.xymon.com/mailman/listinfo/xymon
-- John Horne | Senior Operations Analyst | Technology and Information Services University of Plymouth | Drake Circus | Plymouth | Devon | PL4 8AA | UK
[http://www.plymouth.ac.uk/images/email_footer.gif]<http://www.plymouth.ac.uk/worldclass>
This email and any files with it are confidential and intended solely for the use of the recipient to whom it is addressed. If you are not the intended recipient then copying, distribution or other use of the information contained is strictly prohibited and you should not rely on it. If you have received this email in error please let the sender know immediately and delete it from your system(s). Internet emails are not necessarily secure. While we take every care, University of Plymouth accepts no responsibility for viruses and it is your responsibility to scan emails and their attachments. University of Plymouth does not accept responsibility for any changes made after it was sent. Nothing in this email or its attachments constitutes an order for goods or services unless accompanied by an official order form.
participants (2)
-
john.horne＠plymouth.ac.uk
-
john.thurston＠alaska.gov