...

I have downloaded the latest SVN tarball and am having issues compiling xymon. The error I get is:

In file included from do_rrd.c:546: rrd/do_net.c: In function ‘do_net_rrd’: rrd/do_net.c:123: error: ‘plusminuts’ undeclared (first use in this function) rrd/do_net.c:123: error: (Each undeclared identifier is reported only once rrd/do_net.c:123: error: for each function it appears in.) rrd/do_net.c:131: error: ‘offset’ undeclared (first use in this function)

I have rrdtoool-1.2.23-1 and I notice that this part of the function is not in the version that I am currently running. The code snippet that has the issue is:

if ( offsetdirection && ((strcmp(offsetdirection, "+") == 0) || (strcmp(offsetdirection, "-") == 0)) && plusminuts && (strcmp(plusminus, "+/-") == 0) && secs && (strcmp(secs, "secs") == 0) ) { /* Looks sane */ sprintf(offsetval, "%s%s", offsetdirection, offset); } }

if (offsetval) { sprintf(dataforntpstat, "offset=%s", offset); do_ntpstat_rrd(hostname, testname, classname, pagepaths, dataforntpstat, tstamp); }

Any Ideas?

It's a typo - plusminuts should be plusminus.

Actually the code looks a bit buggy because if the result of the first "if":

if (strstr(msgcopy, "ntpdate") != NULL) {

is true then char *offset won't be declared and could lead to a runtime error in the second "if" statement:

if (offsetval) {

Malcolm

-- Technical copy-editor & proofreader

KDE Proofreading Team KDE British English Translation Team

http://l10n.kde.org/team-infos.php?teamcode=en_GB

Facebook: http://www.facebook.com/FriendlyAtheist

Jetzt kostenlos herunterladen: Internet Explorer 8 und Mozilla Firefox 3.5 - sicherer, schneller und einfacher! http://portal.gmx.net/de/go/chbrowser

On Fri, 2009-11-27 at 19:45 +0100, Malcolm Hunter wrote:

...

...

...

Any Ideas?

It's a typo - plusminuts should be plusminus.

Actually the code looks a bit buggy because if the result of the first "if":

if (strstr(msgcopy, "ntpdate") != NULL) {

is true then char *offset won't be declared and could lead to a runtime error in the second "if" statement:

if (offsetval) {

Correction: it still doesn't compile. I suspect "offset" on line 131 should be "offsetval".

Thanks Malcolm. That compiles now :)

Cheers

Iain

Malcolm