This email is intended for Christoph Berg, the guy who's packaged hobbit 4.2 for the next Debian version and etch-backports, but I thought others might be interested. Keep in mind for this message that I am referring to this specific source package, not the debian directory included in Henrik's original source.
I haven't done an in-depth study, but I've noticed that most of what's in the allinone patch is not included in this packaging effort. When I apply the allinone patch against the source tree after debian/rules applies its patches, only two of the patches fail to apply - the one for ./hobbitd/rrd/do_ncv.c is already applied, and the one for ./hobbitd/wwwfiles/menu/menu_items.js.DIST fails because this file doesn't exist. In fact, the enture hobbitd/wwwfiles/menu directory is empty.
For my production server, I have taken the source package and applied the allinone and bbwin patches to it, but now I am wondering if that was a good idea. Is the allinone patch omitted from the debian package for a good reason? Why is that menu directory empty?
Thanks, Shawn
In <48F513CF.9090401 at elyograg.org> Shawn Heisey <elyograg at elyograg.org> writes:
I haven't done an in-depth study, but I've noticed that most of what's in the allinone patch is not included in this packaging effort. When I apply the allinone patch against the source tree after debian/rules applies its patches, only two of the patches fail to apply - the one for ./hobbitd/rrd/do_ncv.c is already applied, and the one for ./hobbitd/wwwfiles/menu/menu_items.js.DIST fails because this file doesn't exist. In fact, the enture hobbitd/wwwfiles/menu directory is empty.
For my production server, I have taken the source package and applied the allinone and bbwin patches to it, but now I am wondering if that was a good idea. Is the allinone patch omitted from the debian package for a good reason? Why is that menu directory empty?
As I recall, the Debian package uses a different solution for creating the menu - which is probably why the "menu" directory is empty.
Regards, Henrik
Re: Shawn Heisey 2008-10-14 <48F513CF.9090401 at elyograg.org>
This email is intended for Christoph Berg, the guy who's packaged hobbit
4.2 for the next Debian version and etch-backports, but I thought others
might be interested. Keep in mind for this message that I am referring
to this specific source package, not the debian directory included in
Henrik's original source.
Hi Shawn,
Cc'ing me in mails like that makes it a bit earlier for me to actually spot the mail. I only found it now when browsing the hobbitmon-devel list archives...
I haven't done an in-depth study, but I've noticed that most of what's
in the allinone patch is not included in this packaging effort. When I
Right. The reason I had decided not to apply this patch to the Debian package is that it is just a big blob. There are some separate patches for individual features/bugfixes, but it also includes random other fixes. It is also not versioned. There is no real way to track which particular bug is fixed in what instance.
The publically available svn repository is a big step forward as now there's a way to see the diffs and log messages for changes. I am working on uploading a new svn snapshot to the experimental branch of Debian, but have some lose ends left before the next upload.
The next Debian release (5.0, Lenny) will release with the current 4.2.0 packages. Of course, there will be backports of future packages for Lenny.
apply the allinone patch against the source tree after debian/rules
applies its patches, only two of the patches fail to apply - the one for
./hobbitd/rrd/do_ncv.c is already applied, and the one for
That one was pulled in to fix a feature I needed.
./hobbitd/wwwfiles/menu/menu_items.js.DIST fails because this file
doesn't exist. In fact, the enture hobbitd/wwwfiles/menu directory is
empty.
As said in the other mails, the JS code used in the current menu doesn't have a license that Debian thinks is free software. If I remember correctly I had sent the replacement to the mailing list back then, but it didn't get included in the official releases yet. I'll give it another try.
Christoph
cb at df7cb.de | http://www.df7cb.de/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Christoph Berg wrote:
Cc'ing me in mails like that makes it a bit earlier for me to actually spot the mail. I only found it now when browsing the hobbitmon-devel list archives...
Hopefully that means you wanted me to CC you on this :)
Right. The reason I had decided not to apply this patch to the Debian package is that it is just a big blob. There are some separate patches for individual features/bugfixes, but it also includes random other fixes. It is also not versioned. There is no real way to track which particular bug is fixed in what instance.
The publically available svn repository is a big step forward as now there's a way to see the diffs and log messages for changes. I am working on uploading a new svn snapshot to the experimental branch of Debian, but have some lose ends left before the next upload.
The next Debian release (5.0, Lenny) will release with the current 4.2.0 packages. Of course, there will be backports of future packages for Lenny.
Might I suggest the standard Debian practice should be applied? ie, if it is a bug-fix patch or security patch, then it should be applied and a new version released. If it is a feature add/improvement, then it should be added to the version for testing.
I understand right now it is probably difficult to get updated packages in for the Lenny release, but perhaps after Lenny is released you could upload this package for Lenny with all the bug-fix allinone patches applied?
Mostly, I would like to see the new version 5.2.2 released in Lenny, but it is too late for that now :(
Regards, Adam
Adam Goryachev Website Managers www.websitemanagers.com.au -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkkbsp8ACgkQGyoxogrTyiVNXwCdEpXydQxPK3evV9Qg7Vt1Gvb6 ROUAn0zZPJWaw/3eSSmQTiW9qSU8c/3A =ng+C -----END PGP SIGNATURE-----
participants (4)
-
cb＠df7cb.de
-
elyograg＠elyograg.org
-
henrik＠hswn.dk
-
mailinglists＠websitemanagers.com.au