I've just committed version 1.98 to the project repository

Great work Zak! Good to see all this improvement so soon.

I see you are still using something like:

[uint32]$diskusedKB = (uint32) - (uint32) # PS ver 1 doesnt support subtraction uint64's However, there was a report, see attached, about an integer overflow on large filesystems using this, seemingly fixed by removing the [uint32] casts on those lines.

As only PS 1 appears to have that issue, I handled this in my own local mod (reverted to 1.98 now), by simplistically checking the Powershell version before performing the calculation:

    if (($PSVersionTable.PSVersion.Major) -gt 1 ) {
      $diskusedKB = ($d.Capacity/1KB) - ($d.FreeSpace/1KB)
      $disksizeKB = ($d.Capacity/1KB)
    }
    else {
      [uint32]$diskusedKB = ([uint32]($d.Capacity/1KB)) - ([uint32]($d.FreeSpace/1KB))    # PS ver 1 doesnt support subtraction uint64's
      [uint32]$disksizeKB = [uint32]($d.Capacity/1KB)
    }

Maybe you could do something similar, or think of a better approach?

Cheers, Gavin Stone-Tolcher, IT Support Officer, Network Operations and Incident Response Information Technology Services The University of Queensland Level 4, Prentice Building, St Lucia 4072 T: +61 7 334 66645, M: +61 401 140 838 E: g.stone-tolcher at its.uq.edu.au<mailto:g.stone-tolcher at its.uq.edu.au> W: www.its.uq.edu.au<http://www.its.uq.edu.au>

ITS: Service. Team. Accountability. Results.

IMPORTANT: This email and any attachments are intended solely for the addressee(s), contain copyright material and are confidential. We do not waive any legal privilege or rights in respect of copyright or confidentiality. Except as intended addressees are otherwise permitted, you do not have permission to use, disclose, reproduce or communicate any part of this email or its attachments. Statements, opinions and information not related to the official business of The University of Queensland are neither given nor endorsed by us. By using this email (including accessing any attachments or links) you agree we are not liable for any loss or damage of any kind arising in connection with any electronic defect, virus or other malicious code we did not intentionally include.

Please consider the environment before printing this email.

CRICOS Code 00025B

From: Xymon [mailto:xymon-bounces at xymon.com] On Behalf Of zak.beck at accenture.com Sent: Tuesday, 24 February 2015 11:07 PM To: xymon at xymon.com Subject: [Xymon] Windows Xymon PS Client 1.98

Hi

I've just committed version 1.98 to the project repository - http://sourceforge.net/p/xymon/code/HEAD/tree/sandbox/WinPSClient/.

This update has a number of fixes and additions thanks to the suggestions and reaction to the previous patches, thanks to Gavin, Brandon and others for your feedback.

List of changes:

•     Mount points are now shown in the disk section, similar to BBWin. The drive label has been added and the column alignment adjusted to suit drives up to 999TB.

•     The eventlogswanted directive now supports wildcards in the list of event logs field. So you can now return all event logs like this:

eventlogswanted:*:250000

•     The eventlogswanted directive also supports an optional fourth field to specify which levels of event should be returned - critical, error, warning, information, verbose. By default, all are returned. Values in the field should be comma-delimited, e.g.:

eventlogswanted:*:250000:error,warning,critical

•     The dirsize directive now works for files as well as directories.

Thanks to everyone, I really appreciate your feedback.

Regards Zak

And one final one for the list. If this is the final output of "disk" for the new powershell client, then it would be nice if the Xymon server module

xymond/rrd/do_disk.c

could be trained to graph the mountpoints in addition to the driveletter. I am running server v4.3.18 and the mountpoint is not being RRD collected or graphed. I should point out that the BBWIN collected mountpoints were also not being graphed either, so it that sense it is the same situation.

I see we have a couple of windows client types handled in that module, DT_NT and DT_BBWIN. Both of these clients are getting on a bit and it appears that the powershell client might be the way to go for the future with Windows platforms, so maybe DT_PS is needed?

For reference, an example chunk from client message from my test system is:

[disk] Filesystem 1K-blocks Used Avail Capacity Mounted Label Summary(Total\Avail GB) C 104753148 41374564 63378584 39% C:\ SYSTEM 99.90\60.44 MountPointTest 104753148 41374564 63378584 39% C:\MountPointTest\ SYSTEM 99.90\60.44

The module looks to be treating this as BB_NT output as we begin with "Filesystem" like the BB_NT client.

I think this is the codethat might be causing an issue:

if ( (dsystype == DT_NT) && (*(columns[5])) && (strchr(columns[0], '/')) )

where BBNT client would have something like "/FIXED/C" being evaluated?

I attach a previous email to the list where the same issue was seen. In that case modifying the poweshell client to display something like "/FIXED/F:\ORAARCHIVE" for a mountpoint caused the mountpoints to be collected/graphed.

If someone could look into this for a future update it would be appreciated, as my windows guys would like to see graphs for their mountpoints.

Cheers, Gavin Stone-Tolcher, IT Support Officer, Network Operations and Incident Response Information Technology Services The University of Queensland Level 4, Prentice Building, St Lucia 4072 T: +61 7 334 66645, M: +61 401 140 838 E: g.stone-tolcher at its.uq.edu.au<mailto:g.stone-tolcher at its.uq.edu.au> W: www.its.uq.edu.au<http://www.its.uq.edu.au>

ITS: Service. Team. Accountability. Results.

IMPORTANT: This email and any attachments are intended solely for the addressee(s), contain copyright material and are confidential. We do not waive any legal privilege or rights in respect of copyright or confidentiality. Except as intended addressees are otherwise permitted, you do not have permission to use, disclose, reproduce or communicate any part of this email or its attachments. Statements, opinions and information not related to the official business of The University of Queensland are neither given nor endorsed by us. By using this email (including accessing any attachments or links) you agree we are not liable for any loss or damage of any kind arising in connection with any electronic defect, virus or other malicious code we did not intentionally include.

Please consider the environment before printing this email.

CRICOS Code 00025B

From: Xymon [mailto:xymon-bounces at xymon.com] On Behalf Of zak.beck at accenture.com Sent: Tuesday, 24 February 2015 11:07 PM To: xymon at xymon.com Subject: [Xymon] Windows Xymon PS Client 1.98

Hi

I've just committed version 1.98 to the project repository - http://sourceforge.net/p/xymon/code/HEAD/tree/sandbox/WinPSClient/.

This update has a number of fixes and additions thanks to the suggestions and reaction to the previous patches, thanks to Gavin, Brandon and others for your feedback.

List of changes:

•     Mount points are now shown in the disk section, similar to BBWin. The drive label has been added and the column alignment adjusted to suit drives up to 999TB.

•     The eventlogswanted directive now supports wildcards in the list of event logs field. So you can now return all event logs like this:

eventlogswanted:*:250000

•     The eventlogswanted directive also supports an optional fourth field to specify which levels of event should be returned - critical, error, warning, information, verbose. By default, all are returned. Values in the field should be comma-delimited, e.g.:

eventlogswanted:*:250000:error,warning,critical

•     The dirsize directive now works for files as well as directories.

Thanks to everyone, I really appreciate your feedback.

Regards Zak