Xymon 4.3.10 holidays.cfg and Thanksgiving
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi all,
Saw a mention on the list previously about Thanksgiving winding up early on the calendar even though it theoretically is configured correctly in holidays.cfg.
This issue still exists on 4.3.10, which I'm now running in pre-production. I have holidays.cfg set thusly:
Thanksgiving:type=thu month=11 offset=4 Day after Thanksgiving:type=fri month=11 offset=4
...the result is the following:
Thanksgiving 11/21/12 Day after Thanksgiving 11/22/12
...but, of course, 11/21 and 11/22 of 2012 is Wednesday and Thursday, not Thursday and Friday. I'm assuming this is a bug, not a misconfig. And to add a little nudge:
I've seen the issues described with Thanksgiving, but haven't had a chance to look into the problem yet. If you don't hear anything about it, it would be OK to send me a reminder in a months time or so :-)
Regards, Henrik
Thanks in advance, and I'm really happy with 4.3.x and think my colleagues that rely on it will be too!
- ---- _ _ _ _ ___ _ _ _ |Y#| | | |\/| | \ |\ | | |Ryan Novosielski - Sr. Systems Programmer |$&| |__| | | |__/ | \| _| |novosirj at umdnj.edu - 973/972.0922 (2-0922) \__/ Univ. of Med. and Dent.|IST/EI-Academic Svcs. - ADMC 450, Newark -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/
iEYEARECAAYFAlC2bSYACgkQmb+gadEcsb7shQCeKmhquWVNAry6sy7itT1um7S+ cUkAoMzAuJ6TPbOJ/mhyrgxJ6vPzb/4Q =hrXl -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Giving this another bump on the list.
I looked at holidays.c myself, but I'm not seeing anything obviously wrong with the Thursday code or anything like that (I'm no C programmer).
Is there a better way to report a bug?
=R
On 11/28/2012 02:59 PM, Novosielski, Ryan wrote:
Hi all,
Saw a mention on the list previously about Thanksgiving winding up early on the calendar even though it theoretically is configured correctly in holidays.cfg.
This issue still exists on 4.3.10, which I'm now running in pre-production. I have holidays.cfg set thusly:
Thanksgiving:type=thu month=11 offset=4 Day after Thanksgiving:type=fri month=11 offset=4
...the result is the following:
Thanksgiving 11/21/12 Day after Thanksgiving 11/22/12
...but, of course, 11/21 and 11/22 of 2012 is Wednesday and Thursday, not Thursday and Friday. I'm assuming this is a bug, not a misconfig. And to add a little nudge:
I've seen the issues described with Thanksgiving, but haven't had a chance to look into the problem yet. If you don't hear anything about it, it would be OK to send me a reminder in a months time or so :-)
Regards, Henrik
Thanks in advance, and I'm really happy with 4.3.x and think my colleagues that rely on it will be too!
_______________________________________________ Xymon mailing list Xymon at xymon.com http://lists.xymon.com/mailman/listinfo/xymon
- ---- _ _ _ _ ___ _ _ _ |Y#| | | |\/| | \ |\ | | |Ryan Novosielski - Sr. Systems Programmer |$&| |__| | | |__/ | \| _| |novosirj at umdnj.edu - 973/972.0922 (2-0922) \__/ Univ. of Med. and Dent.|IST/EI-Academic Svcs. - ADMC 450, Newark -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/
iEYEARECAAYFAlC/hCQACgkQmb+gadEcsb6zWQCgj1cQ6LGIMsXKOd66ZGvtCu4B CCwAoN9ecXsZ+PRDdy1tGWuJdDuMK+Za =4Rv+ -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Anyone have any word on this now that we're at 4.3.12?
On 12/05/2012 12:28 PM, Novosielski, Ryan wrote:
Giving this another bump on the list.
I looked at holidays.c myself, but I'm not seeing anything obviously wrong with the Thursday code or anything like that (I'm no C programmer).
Is there a better way to report a bug?
=R
On 11/28/2012 02:59 PM, Novosielski, Ryan wrote:
Hi all,
Saw a mention on the list previously about Thanksgiving winding up early on the calendar even though it theoretically is configured correctly in holidays.cfg.
This issue still exists on 4.3.10, which I'm now running in pre-production. I have holidays.cfg set thusly:
Thanksgiving:type=thu month=11 offset=4 Day after Thanksgiving:type=fri month=11 offset=4
...the result is the following:
Thanksgiving 11/21/12 Day after Thanksgiving 11/22/12
...but, of course, 11/21 and 11/22 of 2012 is Wednesday and Thursday, not Thursday and Friday. I'm assuming this is a bug, not a misconfig. And to add a little nudge:
I've seen the issues described with Thanksgiving, but haven't had a chance to look into the problem yet. If you don't hear anything about it, it would be OK to send me a reminder in a months time or so :-)
Regards, Henrik
Thanks in advance, and I'm really happy with 4.3.x and think my colleagues that rely on it will be too!
_______________________________________________ Xymon mailing list Xymon at xymon.com http://lists.xymon.com/mailman/listinfo/xymon
_______________________________________________ Xymon mailing list Xymon at xymon.com http://lists.xymon.com/mailman/listinfo/xymon
____*Note: UMDNJ is now Rutgers-Biomedical and Health Sciences* || \\UTGERS |---------------------*O*--------------------- ||_// Biomedical | Ryan Novosielski - Sr. Systems Programmer || \\ and Health | novosirj at rutgers.edu - 973/972.0922 (2x0922) || \\ Sciences | OIT/EI-Academic Svcs. - ADMC 450, Newark `' -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/
iEYEARECAAYFAlHxfQAACgkQmb+gadEcsb5e2gCcDdfrroLAK4eCPBzq1jqtCRVp 2PEAniN6JiIhl4AecZhWiBpBAXfmFfug =PGMi -----END PGP SIGNATURE-----
Hi,
On 28-11-2012 20:59, Novosielski, Ryan wrote:
Saw a mention on the list previously about Thanksgiving winding up early on the calendar even though it theoretically is configured correctly in holidays.cfg.
This issue still exists on 4.3.10, which I'm now running in pre-production. I have holidays.cfg set thusly:
Thanksgiving:type=thu month=11 offset=4 Day after Thanksgiving:type=fri month=11 offset=4
...the result is the following:
Thanksgiving 11/21/12 Day after Thanksgiving 11/22/12
...but, of course, 11/21 and 11/22 of 2012 is Wednesday and Thursday, not Thursday and Friday. I'm assuming this is a bug, not a misconfig.
I cannot reproduce this, neither with 4.3.10 or 4.3.12 (there hasn't been any code change between the two for this bit of Xymon).
For 2012, Thanksgiving is reported as Nov. 22. For 2013, Thanksgiving is reported as Nov. 28.
According to Wikipedia, Thanksgiving in the US comes on the 4th Thursday of November, so this is correct.
This is with a holidays.cfg config of
Thanksgiving:type=thu month=11 offset=4
Note that "Day after Thanksgiving" cannot be defined! The 4th Friday of November is not necessarily the day after Thanksgiving - in fact, here in 2013 the fourth Friday of November is the 22nd because November begins with a Friday.
You can't really define this in Xymon with the current rules - there is no way to define a holiday of "the day after one of the other days we calculated".
Regards, Henrik
participants (3)
-
henrik＠hswn.dk
-
novosirj＠ca.rutgers.edu
-
novosirj＠umdnj.edu