Re: [hobbit] ncv can´t handle negative values
Just for safety, we should add a plus "+" and a comma "," to the string, in case some source of data provides +9,876.54 as a value.
Thomas Kern 301-903-2211
----- Original Message ----- From: henrik at hswn.dk <henrik at hswn.dk> To: hobbit at hswn.dk <hobbit at hswn.dk> Sent: Mon Feb 19 17:43:02 2007 Subject: Re: [hobbit] ncv can´t handle negative values
On Mon, Feb 19, 2007 at 07:00:48PM +0100, hansi tesarz wrote:
is there an easy way to change the code so that ncv values can handle negative values.
I think there is: In the hobbit-4.2.0/hobbitd/rrd/do_ncv.c file around line 65 there's this line: l = val + strspn(val, "0123456789."); Add a "-" before the numbers so it becomes l = val + strspn(val, "-0123456789."); Run "make" and copy the hobbit-4.2.0/hobbitd/hobbitd_rrd binary to your ~hobbit/server/bin/ directory (or just run "make install"), then restart Hobbit.
Haven't tested it, but I think it should do the trick.
Regards, Henrik
To unsubscribe from the hobbit list, send an e-mail to hobbit-unsubscribe at hswn.dk
On Mon, Feb 19, 2007 at 07:00:44PM -0500, Kern, Thomas wrote:
Just for safety, we should add a plus "+" and a comma "," to the string, in case some source of data provides +9,876.54 as a value.
Agree with the '+', and that is already in my source - but the comma won't work. The value data is passed directly to rrdtool, and it doesn't allow for commas.
It also depends a lot on where you are. Where I come from, that number would be written as "9.876,54" - ie the dot and comma switches place.
Regards, Henrik
Hi
Thanks, it works.
i also changed the dsdef line to -40 instead of zero. sprintf(dsdef, "DS:%s:%s:600:-40:U", dsname, dstype); and recreated the rrd file.
Regards
- hansi
On 2/20/07, Henrik Stoerner <henrik at hswn.dk> wrote:
On Mon, Feb 19, 2007 at 07:00:44PM -0500, Kern, Thomas wrote:
Just for safety, we should add a plus "+" and a comma "," to the string, in case some source of data provides +9,876.54 as a value.
Agree with the '+', and that is already in my source - but the comma won't work. The value data is passed directly to rrdtool, and it doesn't allow for commas.
It also depends a lot on where you are. Where I come from, that number would be written as "9.876,54" - ie the dot and comma switches place.
Regards, Henrik
To unsubscribe from the hobbit list, send an e-mail to hobbit-unsubscribe at hswn.dk
-- Hansi Tesarz Tjäderstigen 7 142 63 Trångsund Tel: +46 708611103 Mail: hansi at htk.se Web: www.htk.se ICQ: 202-468-855 Light Can Twist as Well as Spin
On Tue, Feb 20, 2007 at 06:50:41PM +0100, hansi tesarz wrote:
Thanks, it works.
i also changed the dsdef line to -40 instead of zero. sprintf(dsdef, "DS:%s:%s:600:-40:U", dsname, dstype); and recreated the rrd file.
Thanks for noticing that, I'd missed it. Fixed in my code now.
Regards, Henrik
participants (3)
-
hansi.tesarz＠gmail.com
-
henrik＠hswn.dk
-
Thomas.Kern＠hq.doe.gov