If you have some updates for holidays.cfg, please send them directly to me and I'll get it included in the standard file that ships with Xymon.
I've seen the issues described with Thanksgiving, but haven't had a chance to look into the problem yet. If you don't hear anything about it, it would be OK to send me a reminder in a months time or so :-)
Regards, Henrik
On Wed, 4 Jan 2012 10:31:14 -0600, Taylor Lewick <tlewick at tradebotsystems.com> wrote:
Darin, thanks for the response. I agree with updating the Martin Luther King day. I'm making that change now. I'm guessing by lack of response on the Thanksgiving issue most consider it to not be a big deal. Its easy enough to set a static date, but if a patch/fix is in place I'd add it.
Thanks, Taylor
From: xymon-bounces at xymon.com [mailto:xymon-bounces at xymon.com] On Behalf Of Dugan, Darin D [EIT] Sent: Tuesday, January 03, 2012 3:04 PM To: xymon at xymon.com Subject: Re: [Xymon] Holidays.cfg question
FYI - I noticed the same problem with Thanksgiving after moving from an ancient version to 4.3.7. Both Thanksgiving 2011 and 2012 show one day early on the info pages. Haven't taken the time to debug yet. I thought 2012 might be a leap year bug somehow, but 2011 also has the problem, and my other offset holidays appear correct:
Martin Luther King Jr. Day:type=mon month=1 offset=3 Memorial Day:type=mon month=5 offset=5 Labor Day:type=mon month=9 offset=1 Thanksgiving:type=thu month=11 offset=4
On a related note, Martin Luther King Jr. Day is observed on the 3rd Monday of January in the US, not January 15th (the actual birth date). Would others support changing/correcting the definition in holidays.cfg? It currently has static January 15th.
Cheers.
From: xymon-bounces at xymon.com [mailto:xymon-bounces at xymon.com] On Behalf Of Taylor Lewick Sent: Tuesday, January 03, 2012 8:51 AM To: xymon at xymon.com Subject: [Xymon] Holidays.cfg question
So I updated the holidays.cfg file for static dates in 2012.
After doing this I'm noticing two issues. First, xymon is reporting Thanksgiving for 2012 is on Nov 21st, when it should be Nov 22nd.
Also, for Victoria Day in Canada it is reporting May 25th, and its actually on May 21st.
Here are official and xymon definitions for each. Victoria Day is celebrated on last Monday before May 25th. So this year that would be May 21st.
I tried to use the following definition In holiday.cfg. Victoria Day: type=-mon month=5 day=25
For Thanksgiving in US its just the 4th Thursday of November, hence: Thanksgiving:type=thu month=11 offset=4
I could see where the Victoria Day logic may not be working, perhaps xymon doesn't back off one Monday from May 25th like I think it should. But no clue as to why the Thanksgiving date is incorrect.
Any ideas as to what I'm doing wrong?
Thanks,