On 1/4/2017 11:26 AM, Axel Beckert wrote:
Dear Japheth,
On Wed, Dec 28, 2016 at 07:30:39PM -0800, Japheth Cleaver wrote:
4.3.28 RC1 has been released and should now be available on the SourceForge mirrors. You can download it at https://sourceforge.net/projects/xymon/files/Xymon/4.3.28-rc1/ Thanks!
I'm currently working on integrating this version into the official Debian package (not sure if I'll also upload this RC version, but it's at least for testing it with local deployments).
There's one thing I noticed in Xymon's C code (indentation adjusted):
lib/sendmsg.c: sendresult_t sendmessage(char *msg, char *recipient, int timeout, sendreturn_t *response) lib/sendmsg.h: extern sendresult_t sendmessage(char *msg, char *recipient, int timeout, sendreturn_t *reponse); ^^^
Notice the difference at the end. It probably doesn't have an actual effect on the program, but I think that typo should be fixed anyways.
This and all other typos Debian's lintian tool or myself found so far (mostly in documentation and output strings in C code, occassionally also typos in code comments) are available in https://anonscm.debian.org/cgit/collab-maint/xymon.git/tree/debian/patches/7... (appliable patch at https://anonscm.debian.org/cgit/collab-maint/xymon.git/plain/debian/patches/...)
And then there's also a patch for syntax errors in man pages at https://anonscm.debian.org/cgit/collab-maint/xymon.git/tree/debian/patches/7... respectively https://anonscm.debian.org/cgit/collab-maint/xymon.git/plain/debian/patches/...
You might want to also have a look at these patches we apply in Debian:
- https://anonscm.debian.org/cgit/collab-maint/xymon.git/tree/debian/patches/0... (already posted in the past)
- https://anonscm.debian.org/cgit/collab-maint/xymon.git/tree/debian/patches/1...
- https://anonscm.debian.org/cgit/collab-maint/xymon.git/tree/debian/patches/2... (already posted in the past)
- https://anonscm.debian.org/cgit/collab-maint/xymon.git/tree/debian/patches/3... (already posted in the past)
- https://anonscm.debian.org/cgit/collab-maint/xymon.git/tree/debian/patches/6... (already posted in the past)
- https://anonscm.debian.org/cgit/collab-maint/xymon.git/tree/debian/patches/8... (only recently addeed)
A feature which has been requested in Debian is added by https://anonscm.debian.org/cgit/collab-maint/xymon.git/tree/debian/patches/2... so you might want to have a look at it, too, maybe only for 4.4, though.
Haven't yet tested the built packages, but will do so soon. (And likely send another mail about the results.)
Kind regards, Axel
Thanks! I actually have a patch coming through momentarily for fixing a FTBFS on older openssl's (<1.0.1) and some warnings on F25, so I'll probably be doing a fuller RC2 than expected. Many of these seem simple enough to bring in as well.
-jc