J.C., Sorry for the delay, but I have some updated patches for xymon 4.4 alpha1. I have compiled it on Rocky Linux 8 and 9 64-bit systems. The first set of patches corrects gcc warnings seen on gcc 8.5 (RL8) and 11.4.1 (RL9). I previously sent some patches for these when I tested on RL8 gcc 8.5, but have improved and/or corrected the patches based on RL9 gcc 11.4.1. The second set of patches includes some other bug fixes and enhancements, including:
- build/Makefile.Linux: Check for existence of replacement rpc
- build/Makefile.rules: Add XYMONRUNDIR to CFLAGS
- lib/compression.c: Handle LZ4 versions syntax change
- xymond/client/snmpcollect.c: Initialize nslsects
- xymond/etcfiles/tasks.cfg.DIST: Add IPv6 to admin-senders
- xymond/Makefile: correct missing variable substitutions
- xymond/webfiles/hostgraphs_header: remove XYMWEBHOST hyperlinks
- xymond/xymonfetch.c: Fix gcc warning
- xymond/wwwfiles/gifs/xymonbody.css: Add table td/th classes, tooltips
As a side note, I have also been trying to get a xymon 4.4a1 client to work on an Arm-based NAS system that I have, which the xymon 4.3.30 client is working fine on. I may have more patches to submit once I figure out how to fix it.
Thanks again! Tom Schmidt
On Wed, Oct 4, 2023 at 8:11?AM Tom Schmidt <tom at 4schmidts.com> wrote:
Ralph, thanks for catching and fixing this for the OpenSSL version.
Tom Schmidt
On Tue, Oct 3, 2023 at 10:34?PM Ralph M <ralphmitchell at gmail.com> wrote:
Tom,
I realise that you're working with Rocky 8, but I just want to note that the lib/tcplib.c patch breaks compilation on RHEL7.
The function ASN1_STRING_get0_data() appears in openssl-1.1, but not in RHEL7 / openssl-1.0.
I found that there's an openssl version number in the openssl/opensslv.h include file, which allows the attached patch to select the correct function. With this modification to your patch, the compilation completes on RHEL7, RHEL8 and RHEL9.
Regards,
Ralph Mitchell
On Tue, Oct 3, 2023 at 11:12?PM J.C. Cleaver <cleaver at terabithia.org> wrote:
On Tue, October 3, 2023 13:06, Tom Schmidt wrote:
J.C. and 4.4-alpha1 testers, I have done a little bit of testing of 4.4-alpha1 on Rocky Linux
8.8
(server and client) and on a busybox Linux install on a NAS. I looked into the gcc 8.5.0 compiler warnings that I got on Rocky Linux, and have corrected them, or silenced the ones that should not be an issue. Attached are two context diff patch files, one to fix the compiler warnings, and one to make a couple updates that I had applied to 4.3.30 previously. My updates fix the busybox Linux client build, and enhance the temperature graph to optionally display both Celsius and Fahrenheit readings.
I have not fully tested 4.4-alpha1 yet, but wanted to get thesefirst patches released for 4.4-alpha2.
Tom Schmidt
Thanks for the patches!
Yes, the build errors had been a concern for me as well; determining which sections were protected by correct math and which weren't was going to take some time, and this is quite helpful.
I've created a 4.3.31 branch for similar concerns and many of these are just as applicable there. There's also a corruption bug on some loads that is crashing on F28 (and F29), so that release will probably just be build fixes for the stable tree.
Regards, -jc
Xymon mailing list Xymon at xymon.com http://lists.xymon.com/mailman/listinfo/xymon